Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviour with shared parents on changing the root #6

Open
fcsonline opened this issue Mar 10, 2021 · 9 comments
Open

Weird behaviour with shared parents on changing the root #6

fcsonline opened this issue Mar 10, 2021 · 9 comments

Comments

@fcsonline
Copy link

First of all, thanks for this package! It is awesome! 👏 I really appreciate all the time you invested in it.

I'm using this package to render my family tree, but I'm getting weird behavior when I change the root id. As you can see in the picture there are couples sharing the same parents. I have checked the provided relations and they look ok. It only happens when I change the root. Never happened to me, with the initial root.

image

I'm not sure if is related to this commit you did a few months ago:

SanichKotikov/relatives-tree@71fb50a#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

If I can help with something, I'm open to collaborate

@SanichKotikov
Copy link
Owner

Hi, thanks.

First of all you can try previous version with npm i [email protected] and let me know it it works.
If it doesn't, please share your json here, but don't forget to remove any sensitive data before.

@fcsonline
Copy link
Author

The problem is that the current version of this package requires 2.0.x here:

https://github.com/SanichKotikov/react-family-tree/blob/master/package.json#L37

Maybe I can try to local link but it is always tricky to test.

@fcsonline
Copy link
Author

I just tested with the latest version of relative-tree and the bug continues happening. I'll try to share the smallest json to be able to reproduce the bug.

@fcsonline
Copy link
Author

Wow, I was going a bit mad trying to have a small set of nodes to reproduce the bug, and suddenly I realized that this bug only happens in Firefox. In Chrome is rendered properly :/ Do you know anything about this behavior?

@SanichKotikov
Copy link
Owner

Thanks, I see some problem in Firefox and will try to fix. Maybe it will help.

@SanichKotikov
Copy link
Owner

@fcsonline
Copy link
Author

Awesome, I'll give it a try later. Thanks!

@fcsonline
Copy link
Author

Thank you so much. Now it works as expected in Firefox! 👏

Closing issue.

@fcsonline
Copy link
Author

fcsonline commented Mar 28, 2021

Ouch. Reopening again. There is a weird behavior without changing the rootId. You can see it in the center of the picture. The behavior is exactly the same in Firefox and Chrome.

image

Always it happens with parents that have non-married children. Not sure if this gives you any clue.

@fcsonline fcsonline reopened this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants