Add C++20 module build target #1364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a first working version, I don't know flecs enough for what approaches might be preferred for the define names and usage. |
Gaspard--
force-pushed
the
flecs_cpp20_module
branch
from
ef461d7
to
3191967
Compare
|
Ah, seems my fix for the modularised version of |
|
g++'s module support is incomplete, and the work around seems to big to be worth it right now. |
|
@SanderMertens can I have your thoughts on this approach ? |
Gaspard--
force-pushed
the
flecs_cpp20_module
branch
2 times, most recently
from
ab61d20
to
fe5739f
Compare
Gaspard--
force-pushed
the
flecs_cpp20_module
branch
from
fe5739f
to
adfc478
Compare
Gaspard--
force-pushed
the
flecs_cpp20_module
branch
from
adfc478
to
e03fd47
Compare
Usage in client cmake: ```cmake set(FLECS_M0DULE ON CACHE BOOL "Build flecs module" FORCE) add_subdirectory(path/to/flecs) target_compile_features(flecs-module PUBLIC cxx_std_23) target_link_libraries( someProjectName PRIVATE flecs-module ) ``` In the code, it is then possible to use `import flecs;` to import all the flecs symbols. Still investigating why reflection seems to break, disabled in the module for now. Maintainance: - structs exposed by flecs must be tagged with `FLECS_API_STRUCT` - code within the c++ addon tagged with `FLECS_API` are exposed - globals must be tagged with `FLECS_API_GLOBAL`, which becomes `static` in headers, and export in the module.
Not having it visible breaks compilation on msvc
- Improve define names - Split FLECS_GLOBAL_API in two because `export` comes before template delcarations and `static` afterwards - Fix enum reflection
Gaspard--
force-pushed
the
flecs_cpp20_module
branch
from
e03fd47
to
aaca38d
Compare
|
Closing this PR since #1410 supersedes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage in client cmake:
In the code, it is then possible to use
import flecs;to import all the flecs symbols.Still investigating why reflection seems to break, disabled in the module for now.Fixed.Maintainance:
FLECS_API_STRUCTFLECS_APIare exposedFLECS_API_GLOBAL, which becomesstaticin headers, and export in the module.Closes #1317