Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't embed third party libraries - build them in artifact #22

Open
cardil opened this issue Nov 10, 2017 · 0 comments
Open

Don't embed third party libraries - build them in artifact #22

cardil opened this issue Nov 10, 2017 · 0 comments

Comments

@cardil
Copy link

cardil commented Nov 10, 2017

Third party libraries - scalastyle and scoverage shouldn't be embedded into your library. I't harder to know what exact version is embedded and the upgrade process is not simple.

Instead add them as dependencies and embed them into target artifact using. You can do that in number of ways for ex.: http://maven.apache.org/plugins/maven-shade-plugin/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant