Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Replace AtomTooltip cloneElement by PrimitiveInjector #2317

Closed
andresin87 opened this issue Sep 24, 2022 · 1 comment · Fixed by #2407
Closed

✨Replace AtomTooltip cloneElement by PrimitiveInjector #2317

andresin87 opened this issue Sep 24, 2022 · 1 comment · Fixed by #2407
Assignees
@andresin87
Labels
hacktoberfest refactor code refactor

Comments

@andresin87
Copy link
Member

andresin87 commented Sep 24, 2022 •
edited
Loading

Is your iteration request related to a problem?

No response

Describe the solution you'd like

In the TooltipExtendChildren class
Wrap the TooltipExtendChildren children in an @s-ui/primitiveInjector with the proper props: onClick and className and also the ref

Screenshots

No response

Additional context**

No response

Additional info

No response
@andresin87 andresin87 mentioned this issue Sep 26, 2022
Closed
@nucliweb nucliweb self-assigned this Sep 27, 2022
@andresin87
Copy link
Member Author

sorry @nucliweb this is already closed by the refactor and no longer needed.

This was linked to pull requests Oct 18, 2022
feat(atom/input): refactor #2310
Open
refactor(components/atom/popover): condition error #2407
Merged
This was unlinked from pull requests Oct 18, 2022
feat(atom/input): refactor #2310
Open
refactor(components/atom/popover): condition error #2407
Merged
@andresin87 andresin87 linked a pull request Oct 18, 2022 that will close this issue
refactor(components/atom/popover): condition error #2407
Merged
8 tasks
Repository owner moved this from Todo to Done in Hacktoberfest 2022 🎉 Oct 18, 2022
@andresin87 andresin87 assigned andresin87 and unassigned nucliweb Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andresin87 andresin87

Labels
hacktoberfest refactor code refactor
Projects
No open projects
Hacktoberfest 2022 🎉
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(components/atom/popover): condition error SUI-Components/sui-components
2 participants
@nucliweb @andresin87