Need to add associated actors in ThreatActor

[rpiazza]

No description provided.

[gtback]

@rpiazza, I believe this is already implemented:

https://github.com/STIXProject/python-stix/blob/master/stix/threat_actor/__init__.py#L69
https://github.com/STIXProject/python-stix/blob/master/stix/test/threat_actor_test.py#L55

Can you confirm that this is still needed?

[rpiazza]

I think the issue is that there is no method to add an associated actor. You can have more than 1, so usually there is an add... method in the API in that case. I could always just append, but I thought that wasn't the paradigm.

[bworrell]

A while back, @gtback introduced a couple of base classes that GREATLY help in reducing the amount of code we need to write for STIX fields that have a multiplicity > 1 (i.e., lists).

However, this introduced a new pattern that deviated from the way that we had interacted with these lists in the past. Instead of something.add_foo(bar) calls, you do something.foo.append(bar). Well, we could always do the something.foo.append(bar), but now it is forced since we don't have the associated add_foo() method.

I'd like to go back through the codebase and add the def add_foo(...) methods to our classes where they are missing, just for consistency. This way, developers will be able to interact with these lists directly via the property or via the method.

[rpiazza]

So - for the near future, I should just use the append pattern?

[bworrell]

@rpiazza - Yup!

[gtback]

+1 for append() 😄

[bworrell]

I am going to close this out since we have a way of adding associated threat actors. Issue #117 refrs to the add_foo() pattern.