Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Default Noise Model in execute.py incorrectly uses depolarizing_error for amplitude_damping_error #475

Open
GIRISHBELANI opened this issue May 29, 2024 · 2 comments

Comments

@GIRISHBELANI
Copy link
Contributor

GIRISHBELANI commented May 29, 2024

# Add amplitude damping error to all single qubit gates with error rate 0.0%
#                         and to all two qubit gates with error rate 0.0%
amp_damp_one_qb_error = 0.0
amp_damp_two_qb_error = 0.0
noise.add_all_qubit_quantum_error(depolarizing_error(amp_damp_one_qb_error, 1), ['rx', 'ry', 'rz'])    #line number = 193
noise.add_all_qubit_quantum_error(depolarizing_error(amp_damp_two_qb_error, 2), ['cx'])                 #line number = 194
@rtvuser1
Copy link
Collaborator

rtvuser1 commented Oct 1, 2024

Yes, that does not look right. Can you suggest a simple change that would fix this?

@GIRISHBELANI
Copy link
Contributor Author

Instead of using depolarizing_error(), we can opt for amplitude_damping_error(). However, it only applies to single-qubit errors, as amplitude_damping_error() returns a quantum error channel specific to single-qubit generalized amplitude damping. Therefore, it cannot be directly applied to a two-qubit error model like amp_damp_two_qb_error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants