You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There might be nothing to do, but at least we should think about modal presentations in Play. Modal presentation (whether built-in like form sheet or custom) might not lead to view (dis)appearance methods being called on the covered view, as it never disappears.
We have a full-screen custom presentation for the player and associated view controller presentation methods. We should check this implementation, maybe improve the method names if they should only be used for full-screen modal presentations, and check whether they also support built-in transitions.
We should also check whether our rotation management during modal presentation and dismissal is correct, and investigate whether the view appearance / disappearance behavior is correct.
I doubt there is a silver bullet approach because of the complexity and diversity of modal presentations, but maybe our current API naming is misleading. Having something that works correctly is important, both from a user experience perspective as for analytics.
The text was updated successfully, but these errors were encountered:
There might be nothing to do, but at least we should think about modal presentations in Play. Modal presentation (whether built-in like form sheet or custom) might not lead to view (dis)appearance methods being called on the covered view, as it never disappears.
We have a full-screen custom presentation for the player and associated view controller presentation methods. We should check this implementation, maybe improve the method names if they should only be used for full-screen modal presentations, and check whether they also support built-in transitions.
We should also check whether our rotation management during modal presentation and dismissal is correct, and investigate whether the view appearance / disappearance behavior is correct.
I doubt there is a silver bullet approach because of the complexity and diversity of modal presentations, but maybe our current API naming is misleading. Having something that works correctly is important, both from a user experience perspective as for analytics.
The text was updated successfully, but these errors were encountered: