Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve orientation and view appearance management #184

Open
defagos opened this issue Aug 18, 2021 · 0 comments
Open

Improve orientation and view appearance management #184

defagos opened this issue Aug 18, 2021 · 0 comments
Labels
improvement Feature or update (issue and PR) - release notes section

Comments

@defagos
Copy link
Member

defagos commented Aug 18, 2021

There might be nothing to do, but at least we should think about modal presentations in Play. Modal presentation (whether built-in like form sheet or custom) might not lead to view (dis)appearance methods being called on the covered view, as it never disappears.

We have a full-screen custom presentation for the player and associated view controller presentation methods. We should check this implementation, maybe improve the method names if they should only be used for full-screen modal presentations, and check whether they also support built-in transitions.

We should also check whether our rotation management during modal presentation and dismissal is correct, and investigate whether the view appearance / disappearance behavior is correct.

I doubt there is a silver bullet approach because of the complexity and diversity of modal presentations, but maybe our current API naming is misleading. Having something that works correctly is important, both from a user experience perspective as for analytics.

@defagos defagos added the improvement Feature or update (issue and PR) - release notes section label Aug 18, 2021
@defagos defagos modified the milestone: iOS/3.3.0 - tvOS/1.3.2 Aug 20, 2021
@defagos defagos changed the title Orientation and view appearance management Improve orientation and view appearance management Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

No branches or pull requests

1 participant