Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility for subtitles and audio tracks #504

Closed
3 tasks done
defagos opened this issue Aug 2, 2023 · 5 comments · Fixed by #536
Closed
3 tasks done

Accessibility for subtitles and audio tracks #504

defagos opened this issue Aug 2, 2023 · 5 comments · Fixed by #536
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@defagos
Copy link
Member

defagos commented Aug 2, 2023

As a user who requires accessibility features I want the best possible playback experience tailored to my needs.

Acceptance criteria

  • Audio description tracks are favored if the corresponding accessibility setting has been enabled.
  • SDH subtitles are favored if the corresponding accessibility setting has been enabled. The user experience is identical to Apple system player UI, i.e. the list does not present SDH and non-SDH subtitles were redundant.

Documentation

Tasks

  • Provide AD audio tracks first if enabled in accessibility settings.
  • Provide SDH subtitles first if enabled in accessibility settings. Match the result obtained for the system player and our custom menu with Apple Dolby Atmos sample stream.
  • Document stream packaging recommendations (characteristics and autoselect).
@defagos defagos added this to Pillarbox Aug 2, 2023
@defagos defagos converted this from a draft issue Aug 2, 2023
@defagos defagos added this to the Tracks milestone Aug 2, 2023
@defagos defagos added the enhancement New feature or request label Aug 2, 2023
@defagos
Copy link
Member Author

defagos commented Aug 13, 2023

Likely already implemented in #502 since the system automatically takes into account these settings.

@defagos defagos moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Aug 18, 2023
@defagos defagos moved this from 🚧 In Progress to 🔍 Testing in Pillarbox Aug 18, 2023
@defagos defagos self-assigned this Aug 18, 2023
@defagos
Copy link
Member Author

defagos commented Aug 18, 2023

AD already works well but SDH still needs some work so that the result is identical to the system player UI. Likely something very similar as support for forced subtitles, relying on MACaptionAppearanceCopyPreferredCaptioningMediaCharacteristics.

@defagos defagos moved this from 🔍 Testing to 🚧 In Progress in Pillarbox Aug 18, 2023
@defagos
Copy link
Member Author

defagos commented Aug 18, 2023

I implemented the feature on the sdh-support branch but this branch relies on #533 being merged. Once this PR has been merged we can open the issue branch and cherry-pick the commits.

The idea is to rely on Media Accessibility preferences to prefer CC / SDH when enabled. In this case the normal subtitles are replaced but, if only normal subtitles are available for some language, those will be returned instead. This is what the Apple official player UI does.

We have a slight difference with Apple implementation, which shows CCs when the Accesssibility CC+ SDH flag has not been enabled. This can be observed using the Apple Dolby Atmos sample stream. IMHO our implementation is better since it matches the setting description so I recommend we keep this difference.

Writing tests is a nightmare, though. I don't see how we can achieve something meaningful but this is something we can discuss next week with @waliid.

@defagos
Copy link
Member Author

defagos commented Aug 18, 2023

As for forced subtitles changes made on the Apple TV are partially reflected to the device but there is nothing we can do to fix this issue. It is still a minor issue IMHO.

@defagos defagos moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Aug 18, 2023
@defagos
Copy link
Member Author

defagos commented Aug 21, 2023

Play CH test streams have only public.accessibility.describes-music-and-sound and won't therefore be correctly filtered based on the SDH / CC accessibility setting. Packaging should be updated to add the public.accessibility.transcribes-spoken-dialog as well.

@defagos defagos linked a pull request Aug 21, 2023 that will close this issue
5 tasks
@defagos defagos closed this as completed Aug 21, 2023
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant