-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility for subtitles and audio tracks #504
Comments
Likely already implemented in #502 since the system automatically takes into account these settings. |
AD already works well but SDH still needs some work so that the result is identical to the system player UI. Likely something very similar as support for forced subtitles, relying on |
I implemented the feature on the The idea is to rely on Media Accessibility preferences to prefer CC / SDH when enabled. In this case the normal subtitles are replaced but, if only normal subtitles are available for some language, those will be returned instead. This is what the Apple official player UI does. We have a slight difference with Apple implementation, which shows CCs when the Accesssibility CC+ SDH flag has not been enabled. This can be observed using the Apple Dolby Atmos sample stream. IMHO our implementation is better since it matches the setting description so I recommend we keep this difference. Writing tests is a nightmare, though. I don't see how we can achieve something meaningful but this is something we can discuss next week with @waliid. |
As for forced subtitles changes made on the Apple TV are partially reflected to the device but there is nothing we can do to fix this issue. It is still a minor issue IMHO. |
Play CH test streams have only |
As a user who requires accessibility features I want the best possible playback experience tailored to my needs.
Acceptance criteria
Documentation
Tasks
The text was updated successfully, but these errors were encountered: