Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Password Generator Logic and UI #140

Open
Amansingh0807 opened this issue Jan 11, 2025 · 0 comments
Open

Improve Password Generator Logic and UI #140

Amansingh0807 opened this issue Jan 11, 2025 · 0 comments

Comments

@Amansingh0807
Copy link

The password generator has a few bugs and UX issues that need to be fixed:
Off-by-One Error in the password generation logic causing invalid characters to be selected.

  • State Synchronization Issue: defaultChecked is being used for checkboxes. It should be checked for proper state syncing.
  • Range Input Bug: The value from the range input is a string, which needs to be parsed to an integer before being used for length.
  • UI Improvements: Add padding and update the cursor for password input for better UX. The "copy" button and input field should have improved styling.
  • Accessibility: Ensure labels have html For to improve accessibility.

Fixes Implementation

  • Fixed the off-by-one error in password character selection.
  • Replaced defaultChecked with checked for checkbox inputs.
  • Corrected range input handling by parsing the value to an integer.
  • Enhanced input and button styling for better UX.
  • Added htmlFor to labels for accessibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant