Jormungandr: fix reverse isochrons #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| ep = destinations[0]; | ||
| } | ||
| return navitia::routing::make_isochrone(*planner, ep, request.datetimes(0), |
There was a problem hiding this comment.
Don't you need to specify if ep is the origin or the destination?
|
The direction is fixed by the from/to param in isochrone: from -> clockwise, to -> non-clockwise. Jormungandr should do something about that and kraken or raptor should check the coherence of these params. |
|
you're right I added a test on this |
add tests and then fix the discovered bugs :)
| normal_response, error_code = self.query_no_assert(q) | ||
|
|
||
| assert error_code == 404 | ||
| assert normal_response['error']['message'] == 'isochrone works only for clockwise request' |
|
OK for me |
and return a nice error when no solution found
|
Fine, but you need to update the documentation of isochrone |
TeXitoi
added a commit
that referenced
this pull request
Jul 9, 2015
Jormungandr: fix reverse isochrons
|
🖕 |
|
@stifoon manage your team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isochrons were working only with a 'from'argument, they now also works with only a 'to' argument.
fix http://jira.canaltp.fr/browse/NAVITIAII-1774
@yohanboniface, it should fix your problem, thanks for the bug report!
fixes SNCFdevelopers/API-trains-sncf#7