Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup commented out code and unused code #95

Closed
truedat101 opened this issue Dec 20, 2013 · 1 comment
Closed

Cleanup commented out code and unused code #95

truedat101 opened this issue Dec 20, 2013 · 1 comment
Assignees
@chrqls
Labels
bug p1

Comments

@truedat101
Copy link
Contributor

Please clean up anything that is commented out. Please also remove anything that isn't used, like the deletion methods in QuestionManager that were introduced in #92. Use your discretion as to what else to clean up.
@ghost ghost assigned chrqls Dec 20, 2013
truedat101 added a commit that referenced this issue Dec 20, 2013
@truedat101
refs #91,#95 Fix for deletion handling where we were not checking for
6dbbf36 
any error conditions.  This should be revisited in the future to beef up
JSON handling (I don't parse the JSON from the message body).  For now
we just toast the thing if we succeed or fail.  Let the model update
things.
@chrqls chrqls mentioned this issue Dec 21, 2013
Merged
chrqls pushed a commit that referenced this issue Dec 21, 2013
Merge pull request #99 from chrqls/dev
3251b5d 
[#95] Cleaning projects + merging several constants in the same file: Constants.java
@truedat101
Copy link
Contributor Author

Let's revisit refactoring in #96 . Close.

truedat101 added a commit to RazortoothRTC/smile_teacher_android that referenced this issue Mar 20, 2014
@truedat101
refs #26 Merge tag '0.9.9b1-jamsj'
240b9b4 
* tag '0.9.9b1-jamsj': (95 commits)
  refs SMILEConsortium#106 Bump version string for testing.
  [#4] Adding comments and removing useless ids
  refs SMILEConsortium#105 Remove jamsj string
  refs SMILEConsortium#105 add icon for jamsj.
  refs SMILEConsortium#67 Add proper string and bump version for release.
  [#4] 'Preview iqsets' button is coming... yay! \o/
  [#4] Date format modified in 'use prepared questions' screen
  [#4] Just adding a simple feature to see the number of preloaded questions per IQSet.
  [SMILEConsortium#101] Restart button will alert the teacher if server is down
  [SMILEConsortium#95] Cleaning, removing comments, merging duplicate constants in the same file: Constants.java
  refs SMILEConsortium#91,SMILEConsortium#95 Fix for deletion handling where we were not checking for any error conditions.  This should be revisited in the future to beef up JSON handling (I don't parse the JSON from the message body).  For now we just toast the thing if we succeed or fail.  Let the model update things.
  refs SMILEConsortium#92,SMILEConsortium#93 Undo previous hack, instead, let's let the model update itself via the BoardManager, and fix the server where the problem really exists.  The server only deleted the question from the model where the students receive their questions from, but not from the model where the teacher app gets its data.  Confusing, yes, but we should have been able to debug this by just looking through the teacher and server.
  [SMILEConsortium#92] Fixing little bug when no question in session
  [SMILEConsortium#92] Fixing bug if restarting new session + cleaning + adding comments
  [SMILEConsortium#92] Questions can appear now, even if we crash the teacher app
  [SMILEConsortium#75] Return to teacher data when restart a session
  [#14] Removing 'Highest Rating' + Reparing '% correct'
  [SMILEConsortium#60] Deleting questions only during START_MAKE
  [SMILEConsortium#60] We can delete last question now
  [SMILEConsortium#60] We can 'delete' the questions from teacher app but crap solution...
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrqls chrqls

Labels
bug p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@truedat101 @chrqls