-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set zoom level on markers update #51
Comments
Yes I noticed the recompose library was EOL. Would love to change this to something that better follows react components. I do not particularly like putting majority of the code in one file.
I can try to take a stab at it in the next week or so.
Mihir
…Sent from my iPhone
On Sep 24, 2019, at 8:07 PM, Mike Harrison ***@***.***> wrote:
Going to need some help on this with someone who understands the HOC convention, it is a little over my head coming from Vuejs.
Would like to use this example to center and zoom the map when a set of locations is loaded as markers on the map. I have use in another project and it works great and is light on CPU.
What I need help with is making the markers prop on the MapClass component observable, so we can attach a handler anytime it changes and loop through to create a new bounds object which would then be able to set the zoom level.
Would appreciate anyone's expertise here who knows how to use the recompose library!
Side note: the recompose library is at EOL and will not be receiving future updates which can be a security concern if there are vulnerabilities...maybe we should consider removing this library to accommodate and go more vanilla React?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@mihiramin89 excellent thanks for the help sir! |
Taking this card - will reach out with any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Going to need some help on this with someone who understands the HOC convention, it is a little over my head coming from Vuejs.
Would like to use this example to center and zoom the map when a set of locations is loaded as markers on the map. I have use in another project and it works great and is light on CPU.
What I need help with is making the
markers
prop on theMapClass
component observable, so we can attach a handler anytime it changes and loop through to create a new bounds object which would then be able to set the zoom level.Would appreciate anyone's expertise here who knows how to use the
recompose
library!Side note: the
recompose
library is at EOL and will not be receiving future updates which can be a security concern if there are vulnerabilities...maybe we should consider removing this library to accommodate and go more vanilla React?The text was updated successfully, but these errors were encountered: