Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setAnchor for wc mf in modal #3399

Open
JohannesDoberer opened this issue Aug 16, 2023 · 0 comments · May be fixed by #3761
Open

setAnchor for wc mf in modal #3399

JohannesDoberer opened this issue Aug 16, 2023 · 0 comments · May be fixed by #3761
Assignees
Labels
bug Something isn't working WIP Work in progress

Comments

@JohannesDoberer
Copy link
Contributor

JohannesDoberer commented Aug 16, 2023

tbd

Notice:
Modal will be closed because handleRouteChange calls closeModal.
CloseModal checks the dirty state on iframe mf which is async which means resetMicrofrontendModalData will be called later. We do not have this for wc.

Due to the async resetMicrofrontendModalData, the function await this.shouldShowModalPathInUrl(); will be callled earlier and modal data url won't be lost.

Edit: See discussion here

@JohannesDoberer JohannesDoberer self-assigned this Oct 11, 2023
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jan 8, 2024
@JohannesDoberer JohannesDoberer removed their assignment Jan 29, 2024
@walmazacn walmazacn self-assigned this May 27, 2024
@walmazacn walmazacn linked a pull request May 29, 2024 that will close this issue
@walmazacn walmazacn linked a pull request May 29, 2024 that will close this issue
@hardl hardl added the WIP Work in progress label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants