Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend comment to explain why we shouldn't join the thread for the panic example. #16

Open
mijoharas opened this issue Jan 22, 2021 · 1 comment

Comments

@mijoharas
Copy link

Hi,
Can we extend this comment here on not joining the thread in the panic handler with an explanation as to why? without joining, I worry that any panic crashing my program will be lost and not submitted to rollbar (which is what happens in the example given).

@mijoharas
Copy link
Author

mijoharas commented Jan 22, 2021

also, to clarify, I guess I'm mainly asking what the reason is? otherwise I'd just raised a PR instead of opening this issue, which I'm happy to do ofc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant