This repository has been archived by the owner on Jul 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
make local time message was written appear on timestamp hover #19
Comments
We need to add timezones to the portal son for this, right? |
Don't think so? As long as all message timestamps are written in UTC+0 we can pick up the local TZ from the browser at render time (unless I'm missing something) |
aeonofdiscord
added a commit
to aeonofdiscord/rotonde-client
that referenced
this issue
Oct 21, 2017
ianh
added a commit
that referenced
this issue
Oct 21, 2017
show local time as a tooltip on each entry's timestamp (#19)
"local time message was written" sounds like the author's local time, not the reader's local time, and that pretty much requires a new "timezone offset" field in the portal.json (AFAIK we've got no other means of assuming the author's timezone at the moment). |
I'm 99% sure @aeonofdiscord is right. A JS date, when converted to a number or serialized as a string, is UTC+0. When you read that number/string into a JS date, it applies the local timezone. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
thanks to @Ariganu for the idea!
The text was updated successfully, but these errors were encountered: