Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene Neighborhood and P-Value Filtering #692

Open
Arnedeklerk opened this issue Oct 20, 2022 · 11 comments
Open

Gene Neighborhood and P-Value Filtering #692

Arnedeklerk opened this issue Oct 20, 2022 · 11 comments
Assignees
Labels
new feature Use this for new functionality, for changes about existing features use 'enhancement'.

Comments

@Arnedeklerk
Copy link
Member

Arnedeklerk commented Oct 20, 2022

Part 3 of 3. See 1 & 2.

Both of the below features should be filters added beside the existing key filtering. See my very rough sketch:

Filter

Gene neighbourhood
The introduction of the updated Genome API returning Gene view using JSON, brings visible a visible "Distance" modifier, which I believe goes up to eight. Adding functionality to KnetMiner gene view to be able to cap genes which are at X Distance (hops) away from the seed node would be a great way for users to quickly filter to find the most relevant genes to their query.

It can be in the form of a stepped slider, ranging from 1-8, being default set to 8. There should be an 'i' which explains the functionality with text reading: "Max distance from seed gene(s)." - we can work on the text later.

P-Value filtering
The P-Value is also being returned with the updated format/api.

Let's add a small dropdown where the user can specify an 'Evidence P-Value cutoff', which would remove evidences form the table that the user does not consider to be relevant.

@Arnedeklerk Arnedeklerk added the new feature Use this for new functionality, for changes about existing features use 'enhancement'. label Oct 20, 2022
@Arnedeklerk Arnedeklerk changed the title Gene Neighbourhood Functionality (Genes2PathLengths) Gene neighbourhood Functionality (Genes2PathLengths) Oct 21, 2022
@Arnedeklerk
Copy link
Member Author

Arnedeklerk commented Dec 20, 2022

This will now again be done by us.

Initially we can think of an implementation for gene view, then network view and potentially evidence view.

@Arnedeklerk Arnedeklerk closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2022
@Arnedeklerk Arnedeklerk reopened this Mar 20, 2023
@Arnedeklerk Arnedeklerk changed the title Gene neighbourhood Functionality (Genes2PathLengths) Gene neighbourhood Functionality Mar 21, 2023
@Arnedeklerk Arnedeklerk changed the title Gene neighbourhood Functionality Gene neighbourhood Functionality (Miniature edition) Mar 31, 2023
@Arnedeklerk Arnedeklerk changed the title Gene neighbourhood Functionality (Miniature edition) Gene neighbourhood and P-Value Filtering Mar 31, 2023
@Arnedeklerk
Copy link
Member Author

Just a reminder that @lawal-olaotan we need to brainstorm this a bit before starting with this task. The scope is constantly evolving...

@Arnedeklerk
Copy link
Member Author

I've now updated the ticket to better reflect what I had in mind @lawal-olaotan

@marco-brandizi
Copy link
Member

marco-brandizi commented May 9, 2023

This is now a very different ticket. We might just add a neighbour distance field to the API, but should not start this significant change on the API before having fixed the already too much mess we got for infinite scrolling and filters.

@KeywanHP
Copy link
Member

KeywanHP commented May 9, 2023

It's going to be a great step forward to be able to filter the evidences in Gene View based on their distance, p-value or other values. Note that every evidence will have a distance but p-value is only computed for a Gene List search.

@Arnedeklerk Arnedeklerk changed the title Gene neighbourhood and P-Value Filtering Gene Neighborhood and P-Value Filtering May 12, 2023
@Arnedeklerk
Copy link
Member Author

Arnedeklerk commented Jun 8, 2023

@Arnedeklerk
Copy link
Member Author

FYI future readers:
This is now to be KnetScore and Distance filtering. Filters are to be applied on the columns directly within the table and logic is being changed to never hide the table header.

@Arnedeklerk
Copy link
Member Author

Hi @lawal-olaotan,
image
Still getting the distance bug. I'll take a look briefly too...

@Arnedeklerk
Copy link
Member Author

Distances should be fixed now, @lawal-olaotan please review and please see the TODO re the styling: Reset and Apply/ spacing around box varies between distance and knetscore filters.

@Arnedeklerk
Copy link
Member Author

Going back to 0 concept type filter resets table entirely and removes other filters too

@Arnedeklerk
Copy link
Member Author

Functionality works! Keeping in testing for a while. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Use this for new functionality, for changes about existing features use 'enhancement'.
Projects
None yet
Development

No branches or pull requests

5 participants