-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gene Neighborhood and P-Value Filtering #692
Comments
This will now again be done by us. Initially we can think of an implementation for gene view, then network view and potentially evidence view. |
Just a reminder that @lawal-olaotan we need to brainstorm this a bit before starting with this task. The scope is constantly evolving... |
I've now updated the ticket to better reflect what I had in mind @lawal-olaotan |
This is now a very different ticket. We might just add a neighbour distance field to the API, but should not start this significant change on the API before having fixed the already too much mess we got for infinite scrolling and filters. |
It's going to be a great step forward to be able to filter the evidences in Gene View based on their distance, p-value or other values. Note that every evidence will have a distance but p-value is only computed for a Gene List search. |
Here are the designs by Andrii from Empat: |
FYI future readers: |
Hi @lawal-olaotan, |
Distances should be fixed now, @lawal-olaotan please review and please see the TODO re the styling: Reset and Apply/ spacing around box varies between distance and knetscore filters. |
Going back to 0 concept type filter resets table entirely and removes other filters too |
Functionality works! Keeping in testing for a while. Thanks |
Part 3 of 3. See 1 & 2.
Both of the below features should be filters added beside the existing key filtering. See my very rough sketch:
Gene neighbourhood
The introduction of the updated Genome API returning Gene view using JSON, brings visible a visible "Distance" modifier, which I believe goes up to eight. Adding functionality to KnetMiner gene view to be able to cap genes which are at X Distance (hops) away from the seed node would be a great way for users to quickly filter to find the most relevant genes to their query.
It can be in the form of a stepped slider, ranging from 1-8, being default set to 8. There should be an 'i' which explains the functionality with text reading: "Max distance from seed gene(s)." - we can work on the text later.
P-Value filtering
The P-Value is also being returned with the updated format/api.
Let's add a small dropdown where the user can specify an 'Evidence P-Value cutoff', which would remove evidences form the table that the user does not consider to be relevant.
The text was updated successfully, but these errors were encountered: