Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove JSP tags? #638

Open
marco-brandizi opened this issue May 31, 2022 · 3 comments
Open

Should we remove JSP tags? #638

marco-brandizi opened this issue May 31, 2022 · 3 comments
Labels
chore/infrastructure enhancement Use this for a change about existing functionality, use 'new feature' for new functionality. project:client Related to the client/front-end war.

Comments

@marco-brandizi
Copy link
Member

The Knetminer client is rendered by means of a small JSP/tag library (see .tag files in client-base/).

This is usually done when some modularity is needed, eg, a set of generic widgets to be used to compose an application-specific case. Apart from the fact that nowadays there are simpler ways to do the same using Javascript only, the current code is very Knetmkiner-specific and there isn't much benefit in using tags inside an empty JSP page, wrt using the same HTML code that comes from the tags directly into the JSP.

So, should migrate it to plain JSP?

@marco-brandizi marco-brandizi added enhancement Use this for a change about existing functionality, use 'new feature' for new functionality. project:client Related to the client/front-end war. chore/infrastructure labels May 31, 2022
@KeywanHP
Copy link
Member

Sounds good if it simplifies and modernizes the code base. Do you agree @manlikleo ?

@lawal-olaotan
Copy link
Contributor

Checking the .tag files in the client base, The files structure could be replicated with EJS templating style, also I have little on knowledge with JSP. I can do my own research and suggest ideas.

@marco-brandizi
Copy link
Member Author

This isn't urgent. I've created this issue mostly as a reminder. Let's not start working on new tasks without having first decided we want to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore/infrastructure enhancement Use this for a change about existing functionality, use 'new feature' for new functionality. project:client Related to the client/front-end war.
Projects
None yet
Development

No branches or pull requests

3 participants