Replace 'SparseArrays' by 'StaticArrays' #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the note, of course I meant comparing against SparseArrays (it's a dense-sparse multiplication after all)! Fixed the typo in the plot and in the readme (but the other way around from this PR). ThreadedDenseSparseMul.jl/benchmark/run_and_plot_benchmarks.jl Lines 60 to 61 in 1d6444b |
|
Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that there is a typo in the README.md where you've provided a benchmark against StaticArrays.jl while you've mentioned SparseArrays in the explanation. Either way, there is a typo here. It can be in the plot's legend or the explanation. Please consider fixing it. Thanks.