Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4? #7

Open
spns opened this issue Aug 23, 2016 · 1 comment
Open

Bootstrap 4? #7

spns opened this issue Aug 23, 2016 · 1 comment

Comments

@spns
Copy link
Member

spns commented Aug 23, 2016

Bootstrap 4 is in the works. I suppose we should test/upgrade the code for this.

@kaymes
Copy link

kaymes commented Aug 25, 2016

I don't think that's really necessary at this point.

  • Bootstrap 4 is a complete rewrite, so there will be more than just a
    few changes.
  • They say that they will continue to release important fixes for
    Bootstrap 3 even after 4 is released.
  • Platypus hosts its own copies of all the frameworks, thus we are not
    dependent on any CDN being available and things should continue to work
    even after official support is dropped.

That said, it would probably be worthwhile to look at the bootstrap
package that we pull in via composer. If it is not specifically a
Bootstrap 3 package, it could happen, that the author updates the
package with 4 which means all hell breaks loose if you do a composer
update.
To prevent this, you can restrict the version of the package to be less
than 4. You should be able to specify this in the composer.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants