Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndroidQrCodeProviderWithLogo v6 #142

Closed
YellowMaker opened this issue Oct 24, 2024 · 4 comments
Closed

EndroidQrCodeProviderWithLogo v6 #142

YellowMaker opened this issue Oct 24, 2024 · 4 comments

Comments

@YellowMaker
Copy link
Contributor

I see fix for EndroidQrCodeProvider (#141, #140) but what about EndroidQrCodeProviderWithLogo class?
@willpower232
Copy link
Collaborator

It extends the original one so should be mostly working, are you seeing any specific error messages?

@YellowMaker
Copy link
Contributor Author 

Fatal error:  Uncaught Error: Call to undefined method Endroid\QrCode\Logo\Logo::create() in /var/www/composer/vendor/robthree/twofactorauth/lib/Providers/Qr/EndroidQrCodeWithLogoProvider.php:36
  thrown in /var/www/composer/vendor/robthree/twofactorauth/lib/Providers/Qr/EndroidQrCodeWithLogoProvider.php on line 36

@YellowMaker YellowMaker mentioned this issue Oct 24, 2024
Merged
@YellowMaker
Copy link
Contributor Author

This should work #143

@willpower232
Copy link
Collaborator

Thanks for the PR! Released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willpower232 @YellowMaker