Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Dependency Management #82

Open
abhinavtripathy opened this issue May 5, 2022 · 5 comments
Open

Python Dependency Management #82

abhinavtripathy opened this issue May 5, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@abhinavtripathy
Copy link

Hi,

I was looking at the codebase and I see that venv is used as a python package manager. While this is the default, to scale this project I was wondering if pipenv or poetry would be appropriate as an easy way manage our dependencies as they can get complicated fairly quickly.

@keenanjohnson any thoughts?

@keenanjohnson
Copy link
Member

Hey there!

I'm not an expert, but I've heard that poetry is excellent. In fact, we switched the Frog Sensor package manager to poetry a while ago, so I think it would be great to do that here as well if that's the standard.

@spestana do you have any thoughts or experience on poetry vs pipenv vs venv?

@spestana
Copy link
Contributor

I haven't yet used it myself, but have heard others recommending poetry.

Either way it would be good to be consistent across the board!

@abesto
Copy link
Contributor

abesto commented Jul 22, 2022

In general, Python package management is a bit of a mess :D pipenv and poetry are indeed the major options. I do think adopting poetry here (possibly along with the other devenv goodies in the PR linked above) is a Good Idea (TM). I may do it myself at some point, but also, very happy to review code if someone wants to take on this!

@keenanjohnson
Copy link
Member

@abhinavtripathy are you still working on this issue or should we change it to unassigned for someone else?

@abhinavtripathy
Copy link
Author

@keenanjohnson Thank you for checking In. I have paused on this due to our considering of migration to React. I am looking into the deployment/tech stack and what we can use. I will get back to you on that.

@keenanjohnson keenanjohnson added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants