Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoverComputer.cs - Lon/Lat mode #830

Open
jdmj opened this issue Jul 11, 2021 · 1 comment
Open

RoverComputer.cs - Lon/Lat mode #830

jdmj opened this issue Jul 11, 2021 · 1 comment

Comments

@jdmj
Copy link

jdmj commented Jul 11, 2021

line 273:
if (Delta >= 0.1f) //zero is inpractical due to float nature

I find even this hardcoded value kinda impractical as is. Unless you set speed to literally crawl, RC will miss this 10cm margin and start spinning the rover around almost uncontrollably. The best change would be to expose it in the GUI as a variable, but since Lon/Lat is mostly useful for relatively long trips, increasing it to, say, 10 should be enough.

@jdmj jdmj changed the title RoverComputer.cs RoverComputer.cs - Lon/Lat mode Jul 11, 2021
@jdmj
Copy link
Author

jdmj commented Jul 14, 2021

Come to think of it, if Delta is calculated from CoM to the surface position (which it seems it is), it should probably be compared to something like mVessel.radarAltitude + 1.0f instead of a constant.

jdmj added a commit to jdmj/RemoteTech that referenced this issue Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant