Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Email when page is ready #9

Open
Remeic opened this issue Oct 29, 2018 · 4 comments
Open

Copy Email when page is ready #9

Remeic opened this issue Oct 29, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue for Hacktoberfest

Comments

@Remeic
Copy link
Owner

Remeic commented Oct 29, 2018

instead of click 'copy' button, when page is ready and first email is generated, it will be copied automatically into clipboard

@Remeic Remeic added enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue for Hacktoberfest labels Oct 29, 2018
gkkirilov added a commit to gkkirilov/genesia that referenced this issue Oct 29, 2018
ThomasNolte added a commit to ThomasNolte/genesia that referenced this issue Oct 30, 2018
componentDidMount excutes once, after the page has rendered successfully.
@ThomasNolte
Copy link

Let me know if my fix #19 was what you were looking for or if you wanted it implemented in a more thorough way like #10.

@Remeic

@Remeic
Copy link
Owner Author

Remeic commented Oct 30, 2018

Hi @ThomasNolte , thanks for contributing to this project.
I believe that #19 is the better solution for now, i have some dubt on 10.
You think that in 10 email is copied every time 'generate' button is pressed?

@ThomasNolte
Copy link

it does seem that in 10 the email is copied every time the generate button is pressed which could eliminate the use of the copy button because every time the page loads and updates the email is being copied.

you could achieve the same effect by using the componentDidUpdate function for an more React style solution.

@Remeic
Copy link
Owner Author

Remeic commented Nov 1, 2018

@ThomasNolte Hi, yes it also seemed to me that this result was obtained, but that is not the desired one. I accept your PR.

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants