Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throws exceptions early, catch them late #24

Open
fidransky opened this issue Feb 9, 2019 · 2 comments
Open

throws exceptions early, catch them late #24

fidransky opened this issue Feb 9, 2019 · 2 comments
Assignees
@tomasSimandl
Labels
enhancement New feature or request

Comments

@fidransky
Copy link
Collaborator

Example: SaveDiagram servlet always returns success even though some error occurs in database because SQLExceptions get swallowed right when they are thrown in the DB class.

Follow Throw early, catch late principle to handle errors properly.
@fidransky fidransky added the enhancement New feature or request label Feb 9, 2019
tomasSimandl added a commit that referenced this issue Feb 11, 2019
@tomasSimandl
#24 throws exceptions early, catch them late
092ba8c 
- throw own exception and handle it with error page
@tomasSimandl
Copy link
Collaborator

Data access layer throws own exception which is handled with an error page.

@fidransky can you please make a small review if it is correct.

@fidransky
Copy link
Collaborator Author

Awesome! Will do.

tomasSimandl added a commit that referenced this issue Feb 11, 2019
@tomasSimandl
#24 throws exceptions early, catch them late
b40af38 
- minor fix (possibility to work without db)
janpasek97 added a commit that referenced this issue Dec 17, 2021
@janpasek97
Merge pull request #24 from janpasek97/frontend-vue-edge-description
54db0b5 
Issue #22 fixed displaying edges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasSimandl tomasSimandl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fidransky @tomasSimandl