Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorization constraint outputs in the correct ordering #144

Conversation

wouterwln
Copy link
Member

Completely overhauls graph implementation so please don't merge yet. First discuss if we want to go down this road.

@wouterwln wouterwln linked an issue Nov 27, 2023 that may be closed by this pull request
@wouterwln wouterwln changed the base branch from main to dev-4.0.0 November 27, 2023 14:34
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (029c6d8) 89.96% compared to head (8c6386a) 92.50%.
Report is 3 commits behind head on dev-4.0.0.

Files Patch % Lines
src/graph_engine.jl 86.66% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           dev-4.0.0     #144      +/-   ##
=============================================
+ Coverage      89.96%   92.50%   +2.54%     
=============================================
  Files              9        9              
  Lines           1425     1401      -24     
=============================================
+ Hits            1282     1296      +14     
+ Misses           143      105      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wouterwln wouterwln force-pushed the 140-factorization-constraints-are-not-outputted-in-the-right-order branch from a4eba05 to 18d3488 Compare November 27, 2023 15:23
@wouterwln wouterwln marked this pull request as ready for review November 27, 2023 16:09
@wouterwln wouterwln changed the title [DO NOT MERGE] factorization constraint outputs in the correct ordering Factorization constraint outputs in the correct ordering Nov 28, 2023
@wouterwln wouterwln merged commit d36053b into dev-4.0.0 Nov 28, 2023
4 of 5 checks passed
@wouterwln wouterwln deleted the 140-factorization-constraints-are-not-outputted-in-the-right-order branch November 28, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factorization constraints are not outputted in the right order
1 participant