Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenGraph Tags #35

Open
okonet opened this issue Jan 30, 2018 · 10 comments
Open

Improve OpenGraph Tags #35

okonet opened this issue Jan 30, 2018 · 10 comments
Labels

Comments

@okonet
Copy link

okonet commented Jan 30, 2018

Right now Ken's image is being displayed:

2018-01-30 at 09 22

@bebraw
Copy link
Collaborator

bebraw commented Jan 30, 2018

Good point. What's a good way to test this? What to display instead?

@bebraw bebraw added the bug label Jan 30, 2018
@okonet
Copy link
Author

okonet commented Jan 30, 2018

No idea. Needs research. Please post here when found

@okonet
Copy link
Author

okonet commented Jan 30, 2018

I'd display the logo (probably will need a separate asset)

@bebraw
Copy link
Collaborator

bebraw commented Jan 30, 2018

Ok, logo is simple to pull off. It's just a reference through the EJS template and maybe some copy bit.

@okonet
Copy link
Author

okonet commented Jan 30, 2018

Related: gatsbyjs/gatsby#2829

@bebraw
Copy link
Collaborator

bebraw commented Jan 30, 2018

Ok. Note that I'm not using react-helmet yet.

@okonet
Copy link
Author

okonet commented Jan 30, 2018

Probably you'll need it anyway to control document title etc. or how it's done now?

Re: image — probably it needs to be an image of a specific size. If you can find any guides, please post here.

@bebraw
Copy link
Collaborator

bebraw commented Jan 30, 2018

Here: https://github.com/ReactFinland/site/blob/master/templates/page.ejs#L14 .

I agree, it's in a spec somewhere.

@okonet
Copy link
Author

okonet commented Jan 30, 2018

@okonet
Copy link
Author

okonet commented Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants