Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log IQSet JSON parse errors at debug level, log at warn #4

Open
chrqls opened this issue Feb 15, 2014 · 1 comment
Open

Don't log IQSet JSON parse errors at debug level, log at warn #4

chrqls opened this issue Feb 15, 2014 · 1 comment

Comments

@chrqls
Copy link

chrqls commented Feb 15, 2014

Relative issue: SMILEConsortium#98
@chrqls
Copy link
Author

chrqls commented Feb 15, 2014

D/SMILE Teacher(18436): Status = START_MAKE
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC
D/SMILE IQSetJSONParser(18436): Failed parsing JSON, reason: No value for PIC

chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Bye bye local files, now prepared questions will have to be uplo…
f11c088 
…aded through smile-iqmanager before getting it on the teacher app
truedat101 pushed a commit that referenced this issue Mar 20, 2014
Merge pull request #46 from chrqls/dev
8c66409 
[#4]  Replacing local files by IQSets uploaded from iq-manager
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Upgrading 'use prepared questions' for large and x-large format …
9b96167 
…+ fixing a bug exclusive to x-large format
truedat101 pushed a commit that referenced this issue Mar 20, 2014
Merge pull request SMILEConsortium#48 from chrqls/dev
53f31b9 
[#4] Managing large and x-large format
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Use prepared questions for mobile format
ca6d40c
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Adding date to the prepared iqsets
216b25b
truedat101 pushed a commit that referenced this issue Mar 20, 2014
Merge pull request SMILEConsortium#61 from chrqls/dev
9cc3bab 
[#4] Adding date on prepared questions screen
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Just adding a simple feature to see the number of preloaded ques…
23f9c7a 
…tions per IQSet.
truedat101 pushed a commit that referenced this issue Mar 20, 2014
Merge pull request SMILEConsortium#103 from chrqls/dev
f2f14db 
 [#4] Adding the number of questions preloaded per IQSet
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Date format modified in 'use prepared questions' screen
a7000f5
truedat101 pushed a commit that referenced this issue Mar 20, 2014
Merge pull request SMILEConsortium#104 from chrqls/dev
76b6e20 
[#4] Better interface for  'use prepared questions' screen, date format modified
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] 'Preview iqsets' button is coming... yay! \o/
faf2982
chrqls added a commit that referenced this issue Mar 20, 2014
@chrqls
[#4] Adding comments and removing useless ids
895245a
truedat101 pushed a commit that referenced this issue Mar 20, 2014
Merge pull request SMILEConsortium#107 from chrqls/dev
51f5df8 
[#4] Adding "preview iqset" button in the list of iqsets
truedat101 added a commit that referenced this issue Mar 20, 2014
@truedat101
refs #26 Merge tag '0.9.9b1-jamsj'
240b9b4 
* tag '0.9.9b1-jamsj': (95 commits)
  refs SMILEConsortium#106 Bump version string for testing.
  [#4] Adding comments and removing useless ids
  refs SMILEConsortium#105 Remove jamsj string
  refs SMILEConsortium#105 add icon for jamsj.
  refs SMILEConsortium#67 Add proper string and bump version for release.
  [#4] 'Preview iqsets' button is coming... yay! \o/
  [#4] Date format modified in 'use prepared questions' screen
  [#4] Just adding a simple feature to see the number of preloaded questions per IQSet.
  [SMILEConsortium#101] Restart button will alert the teacher if server is down
  [SMILEConsortium#95] Cleaning, removing comments, merging duplicate constants in the same file: Constants.java
  refs SMILEConsortium#91,SMILEConsortium#95 Fix for deletion handling where we were not checking for any error conditions.  This should be revisited in the future to beef up JSON handling (I don't parse the JSON from the message body).  For now we just toast the thing if we succeed or fail.  Let the model update things.
  refs SMILEConsortium#92,SMILEConsortium#93 Undo previous hack, instead, let's let the model update itself via the BoardManager, and fix the server where the problem really exists.  The server only deleted the question from the model where the students receive their questions from, but not from the model where the teacher app gets its data.  Confusing, yes, but we should have been able to debug this by just looking through the teacher and server.
  [SMILEConsortium#92] Fixing little bug when no question in session
  [SMILEConsortium#92] Fixing bug if restarting new session + cleaning + adding comments
  [SMILEConsortium#92] Questions can appear now, even if we crash the teacher app
  [SMILEConsortium#75] Return to teacher data when restart a session
  [#14] Removing 'Highest Rating' + Reparing '% correct'
  [SMILEConsortium#60] Deleting questions only during START_MAKE
  [SMILEConsortium#60] We can delete last question now
  [SMILEConsortium#60] We can 'delete' the questions from teacher app but crap solution...
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrqls