Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher app needs to handle "retake" scenario #23

Closed
chrqls opened this issue Feb 15, 2014 · 11 comments
Closed

Teacher app needs to handle "retake" scenario #23

chrqls opened this issue Feb 15, 2014 · 11 comments
Assignees

Comments

@chrqls
Copy link

chrqls commented Feb 15, 2014

Relative issue: SMILEConsortium#7

@chrqls
Copy link
Author

chrqls commented Feb 15, 2014

screen shot 2014-02-15 at 03 57 33

@chrqls
Copy link
Author

chrqls commented Feb 15, 2014

screen shot 2014-02-15 at 03 58 57

@truedat101
Copy link
Member

@chrqls can you look into this feature? It's partially implemented. JAMsj would like this feature done in this manner:

  • Teacher selects retake from menu.
  • Server resets scores, drops all current questions, but leaves the students logged into the session
  • Student devices are sent back to "start making questions" phase. They aren't logged out.

@truedat101
Copy link
Member

The use case for JAMsj is to easily send out a new batch of questions without forcing all students to re-login.

@chrqls
Copy link
Author

chrqls commented Mar 3, 2014

I identified a problem with the json request caught on server side, but I did not find a solution for now

format I need

{"MSG":"{\"TYPE\":\"HAIL\",\"IP\":\"127.0.0.239\",\"NAME\":\"mac\"}"}

format we have

{"MSG\":\"{\"RANSWER\":[4,4,4,4],\"TIME_LIMIT\":10,\"NUMQ\":4}\"}":""}

For a reason I cannot explain for now, the json is not wrapped correctly when I call .
I try to change that.

@truedat101
Copy link
Member

There's probably bugs in the "retake" because this was never completely implemented. The code partially exists on both sides. As you can see @thiago didn't completely finish this feature. I would like it if you can focus on this, how to implement per the JAMsj requirement:

  • Teacher runs a session with prepared question set A
  • Teacher completes session, would like to run prepared question Set B.
  • Teacher hits "Send New IQSet" button
  • This should restart the teacher tablet, with the selection of prepared questions
  • Once selected an iqset, students are reset to "Start Answer Questions Phase" without being logged out, and all existing scores are reset.

Note, this requires a server side change as well.

chrqls added a commit to chrqls/smile_teacher_android that referenced this issue Mar 24, 2014
… way to reload the top buttons to initial state
chrqls added a commit that referenced this issue Mar 24, 2014
chrqls added a commit to chrqls/smile_teacher_android that referenced this issue Apr 1, 2014
chrqls added a commit that referenced this issue Apr 1, 2014
[#23] Reverting buttons and checkboxes
chrqls added a commit to chrqls/smile_teacher_android that referenced this issue Apr 2, 2014
chrqls added a commit to chrqls/smile_teacher_android that referenced this issue Apr 3, 2014
chrqls added a commit that referenced this issue Apr 3, 2014
[#23] Retake scenario is working now
@truedat101 truedat101 reopened this Apr 9, 2014
@truedat101
Copy link
Member

Feature is not fixed or not working as intended. When the teacher performs retake, everything goes fine in the teacher interface. However, in the SMILE Student Web app, they don't receive questions. The question count is 1/0 ...

Did you verify this before closing? Please provide a screenshot for verification purposes, and let me handle closing of the issue as verification.

@truedat101
Copy link
Member

After "retake"

screenshot_2014-04-08-22-19-48

After teacher hits "Start Answer Questions"

screenshot_2014-04-08-22-23-44

@truedat101
Copy link
Member

Note, there are no questions. Dataset used is from an uploaded XLS spreadsheet.

@chrqls
Copy link
Author

chrqls commented Apr 11, 2014

This problem won't appear anymore now. The students won't get empty questions with this new fix on node-smile-server. Henceforth, the teacher is also able to delete questions from a retaken iqset.

chrqls added a commit to chrqls/smile_teacher_android that referenced this issue Apr 11, 2014
chrqls added a commit that referenced this issue Apr 11, 2014
[#23] Removing the cross in {Use prepared questions} layout when retaking
@truedat101
Copy link
Member

verified.

truedat101 added a commit that referenced this issue May 17, 2014
* commit '866a89e90ba0ba92166d019a7aee3933e653bf3c':
  refs #41 Bump version to 0.9.9b5 based on the code from April 17th.
  [#17] Fixing bug on general layout for mobile format
  [#17] Updating UI for mobile format.
  [#33] New login page for Nexus 7 2nd generation
  refs #34 Bump version to 0.9.9b4
  [#23] Removing the cross in {Use prepared questions} layout when retaking
  [#21] Teacher will now see the difference when a session is already running
  Applying same design layout on nexus 7 format than mobile for GeneralActivity
  [#23] Removing top score panel when retaking
  [#23] Reverting result button to 'show results'
  [#23] Reverting buttons to initial state, uncheck checkboxes, dropping ratings and answers
  Restoring project.properties
  Delete project.properties
  [#23] Retake button uploaded but we still need to find a way to reload the top buttons to initial state

Conflicts:
	project.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants