Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the smilestudent.js lint #28

Open
chrqls opened this issue Feb 15, 2014 · 2 comments
Open

Fix the smilestudent.js lint #28

chrqls opened this issue Feb 15, 2014 · 2 comments

Comments

@chrqls
Copy link

chrqls commented Feb 15, 2014

Relative issue: SMILEConsortium#38

@chrqls
Copy link
Author

chrqls commented Feb 15, 2014

static/js/smilestudent.js: line 42, col 2, Missing semicolon.
static/js/smilestudent.js: line 116, col 2, Missing semicolon.
static/js/smilestudent.js: line 153, col 2, Missing semicolon.
static/js/smilestudent.js: line 158, col 23, Use '!==' to compare with ''.
static/js/smilestudent.js: line 158, col 42, Use '!==' to compare with ''.
static/js/smilestudent.js: line 158, col 61, Use '!==' to compare with ''.
static/js/smilestudent.js: line 158, col 80, Use '!==' to compare with ''.
static/js/smilestudent.js: line 158, col 108, Use '!==' to compare with ''.
static/js/smilestudent.js: line 158, col 133, Use '!==' to compare with ''.
static/js/smilestudent.js: line 159, col 2, Missing semicolon.
static/js/smilestudent.js: line 163, col 27, Use '!==' to compare with ''.
static/js/smilestudent.js: line 164, col 2, Missing semicolon.
static/js/smilestudent.js: line 177, col 2, Missing semicolon.
static/js/smilestudent.js: line 190, col 2, Missing semicolon.
static/js/smilestudent.js: line 209, col 2, Missing semicolon.
static/js/smilestudent.js: line 237, col 2, Missing semicolon.
static/js/smilestudent.js: line 244, col 2, Missing semicolon.
static/js/smilestudent.js: line 267, col 2, Missing semicolon.
static/js/smilestudent.js: line 316, col 2, Missing semicolon.
static/js/smilestudent.js: line 373, col 1, Mixed spaces and tabs.
static/js/smilestudent.js: line 371, col 51, Bad escaping of EOL. Use option multistr if needed.
static/js/smilestudent.js: line 372, col 14, Bad escaping of EOL. Use option multistr if needed.
static/js/smilestudent.js: line 373, col 50, Bad escaping of EOL. Use option multistr if needed.
static/js/smilestudent.js: line 396, col 21, Missing semicolon.
static/js/smilestudent.js: line 413, col 16, 'i' is already defined.
static/js/smilestudent.js: line 423, col 16, You might be leaking a variable (dice) here.
static/js/smilestudent.js: line 430, col 9, Comma warnings can be turned off with 'laxcomma'.
static/js/smilestudent.js: line 429, col 34, Bad line breaking before ','.
static/js/smilestudent.js: line 430, col 45, ['echoclientip'] is better written in dot notation.
static/js/smilestudent.js: line 449, col 17, 'clientip' is already defined.
static/js/smilestudent.js: line 450, col 76, ['pushmsg'] is better written in dot notation.
static/js/smilestudent.js: line 468, col 34, Bad line breaking before ','.
static/js/smilestudent.js: line 469, col 53, ['getresults'] is better written in dot notation.
static/js/smilestudent.js: line 478, col 76, ['postinquiry'] is better written in dot notation.
static/js/smilestudent.js: line 500, col 76, ['submitanswers'] is better written in dot notation.
static/js/smilestudent.js: line 521, col 83, ['getinquiry'] is better written in dot notation.
static/js/smilestudent.js: line 542, col 51, ['defaultpicurl'] is better written in dot notation.
static/js/smilestudent.js: line 560, col 75, ['smsg'] is better written in dot notation.
static/js/smilestudent.js: line 564, col 23, ['TYPE'] is better written in dot notation.
static/js/smilestudent.js: line 571, col 13, Unnecessary semicolon.
static/js/smilestudent.js: line 584, col 13, Unnecessary semicolon.
static/js/smilestudent.js: line 587, col 13, Unnecessary semicolon.
static/js/smilestudent.js: line 603, col 52, Missing semicolon.
static/js/smilestudent.js: line 641, col 23, '$next' is already defined.
static/js/smilestudent.js: line 646, col 23, 'a' is already defined.
static/js/smilestudent.js: line 647, col 25, 'evt' is already defined.
static/js/smilestudent.js: line 649, col 130, Missing semicolon.
static/js/smilestudent.js: line 656, col 23, '$next' is already defined.
static/js/smilestudent.js: line 661, col 23, 'a' is already defined.
static/js/smilestudent.js: line 662, col 25, 'evt' is already defined.
static/js/smilestudent.js: line 662, col 25, Too many errors. (69% scanned).

@chrqls
Copy link
Author

chrqls commented Feb 15, 2014

screen shot 2014-02-15 at 03 01 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant