Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Virtual-DOM and DOM-Delegator implicit peer dependency #122

Open
kumavis opened this issue Jan 28, 2015 · 5 comments
Open

Virtual-DOM and DOM-Delegator implicit peer dependency #122

kumavis opened this issue Jan 28, 2015 · 5 comments
Labels

Comments

@kumavis
Copy link
Collaborator

kumavis commented Jan 28, 2015

Discovered this when using a later version of virtual-dom that uses ev-store instead of data-set. dom-delegator expects data-set. Ideally this would be decoupled instead of just moving to ev-store.

22:17 <kumavis> Raynos: playing with mercury, getting some weird behaviour
22:18 <kumavis> somehow event registration is not working?
22:55 <kumavis> Raynos: I think it was latest that im manually brininging in modules instead of using mercury and the latest virtual-dom is not compatible somehow
22:57 <kumavis> Raynos: just confirmed this to be true
23:22 <kumavis> ah ok that took awhile, but there is an implicit expectation that virtual-dom and DOMDelegator are both using data-set
23:23 <kumavis> later virtual-dom uses ev-store instead
@kumavis
Copy link
Collaborator Author

kumavis commented Jan 28, 2015

I'm not sure what other requirements there are to upgrade

@Raynos
Copy link
Owner

Raynos commented Feb 5, 2015

@kumavis just published mercury@13 to fix this.

I dont really know how to fix this peer dependency.

@kumavis kumavis added the bug label Feb 6, 2015
@neonstalwart
Copy link
Collaborator

I believe the open issue is that there is an implicit peer dependency where dom-delegator and virtual-dom need to be sharing a reference to the same ev-store. if they each got their own copy then it won't work.

@kumavis
Copy link
Collaborator Author

kumavis commented Feb 15, 2015

seems like vdom should supply its ev-store obj and dom-delegator should take it in

right now its just magic that they end up with the same thing

@neonstalwart
Copy link
Collaborator

@kumavis 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants