-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specs with "container" width do not render #120
Comments
Hi Ben, Is that container width setting new? I have not updated to the latest vega or vega-lite libs. Yeah, send me a PR if you know the fix. Thanks |
Great, I'll work on this next week, it probably boils down to setting a width or height on the spec's config. |
@bbenzikry is this still the case? I never got your PR to get containers width fixed. Also, do you have a simple example or a screenshot that illustrates the container width issue? |
Hi @RandomFractals, sorry for the late response. |
@bbenzikry oh, I see now. So, we'll need to set that view to container width. I'll look into it on the next vega libs update. @domoritz do I need to set or pass view container width param for this to work in vega lite? Thanks for the screenshots! |
No, I think we read the size of the surrounding element. Take a look at a spec with container sizing in the Vega editor. |
@domoritz will do on the next vega libs update. |
Hi there, thanks a lot for the work you put in, we use the extension every day 👍
As the title mentions, a simple spec with "width":"container" won't work.
Do you think it would be possible to patch the CSS or the spec itself in that case?
I can PR in a week or so if you don't have the time.
The text was updated successfully, but these errors were encountered: