Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs with "container" width do not render #120

Open
bbenzikry opened this issue Dec 14, 2020 · 8 comments
Open

specs with "container" width do not render #120

bbenzikry opened this issue Dec 14, 2020 · 8 comments

Comments

@bbenzikry
Copy link

Hi there, thanks a lot for the work you put in, we use the extension every day 👍
As the title mentions, a simple spec with "width":"container" won't work.
Do you think it would be possible to patch the CSS or the spec itself in that case?
I can PR in a week or so if you don't have the time.

@RandomFractals
Copy link
Owner

Hi Ben,

Is that container width setting new?

I have not updated to the latest vega or vega-lite libs.

Yeah, send me a PR if you know the fix.

Thanks

@bbenzikry
Copy link
Author

Great, I'll work on this next week, it probably boils down to setting a width or height on the spec's config.
As for the setting, it was added a bit over a year ago as far as I can tell.

@RandomFractals
Copy link
Owner

@bbenzikry is this still the case? I never got your PR to get containers width fixed.

Also, do you have a simple example or a screenshot that illustrates the container width issue?

@bbenzikry
Copy link
Author

Hi @RandomFractals, sorry for the late response.
I'll have a look at it next week and see if it still reproduces. I'll share an example if it does.

@RandomFractals RandomFractals changed the title Specs with "container" width do not render specs with "container" width do not render Nov 21, 2021
@bbenzikry
Copy link
Author

Renders preview normally

image

image

Doesn't render
image

@RandomFractals
Copy link
Owner

RandomFractals commented Nov 27, 2021

@bbenzikry oh, I see now. So, we'll need to set that view to container width. I'll look into it on the next vega libs update.

@domoritz do I need to set or pass view container width param for this to work in vega lite?

Thanks for the screenshots!

@domoritz
Copy link
Contributor

No, I think we read the size of the surrounding element. Take a look at a spec with container sizing in the Vega editor.

@RandomFractals
Copy link
Owner

@domoritz will do on the next vega libs update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants