Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with all mods that add special shafts and encased cogwheels #83

Open
hlysine opened this issue Dec 31, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@hlysine
Copy link

hlysine commented Dec 31, 2023

Describe the bug
This is similar to #75 but with an expanded scope. The current code of Extended Cogwheels causes a lot of incompatibility with other mods due to the way it patches commonly used renderers/instances, assuming that Create's cogwheels are the only blocks that use those renderers.

First, the patch on BracketedKineticBlockEntityRenderer assumes that all blocks that use such a renderer (except Create's original shaft) are cogwheels. This breaks all modded shafts with special functions, such as special shafts in Create Encased and shear pins in Create: Connected.
image

Second, the patch on EncasedCogRenderer forces casings to be rendered, which causes z-fighting on add-on blocks that use this renderer but have block models.
image

In general, I don't think it is a good idea for Extended Cogwheels to patch these commonly re-used renderers. There should at least be checks to make sure that only Create's blocks are modified, but a better way to implement this is to add a new block type for cogwheels in other material types, so that the effect is limited to blocks that Extended Cogwheels explicitly support. If this is too much work, an API from Extended Cogwheels for us to disable the patches would also be nice.

To Reproduce
Steps to reproduce the behavior:
Install Create: Extended Cogwheels with any mods that add special shafts/encased blocks.

Expected behavior
Create: Extended Cogwheels should not change the rendering of blocks from other mods.

Loader & Other Mods:

  • Forge
  • Create: Connected

Additional context
Note: I am the developer of Create: Connected.

@ghost
Copy link

ghost commented Feb 4, 2024

Can confirm this bug is happening to me too.

@xephosarkeyus
Copy link

I've found that disabling Flywheel's renderer can fix this, but obviously that's not a very good fix performance-wise.

I'm surprised there still hasn't been a fix for this yet, it's been a few months...

@petrolpark
Copy link

Also applies to Petrol's Parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants