Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large crafting requests get stuck #1655

Open
megarobo12222 opened this issue Mar 7, 2022 · 1 comment
Open

Large crafting requests get stuck #1655

megarobo12222 opened this issue Mar 7, 2022 · 1 comment
Assignees
Labels
Accepted Will be fixed or implemented Bug
Milestone

Comments

@megarobo12222
Copy link

I ran into the following problem when playing a modpack with LP. If I want to craft 8000 of a certain item (recipe below), the LP system can not process this request.
afbeelding

What happens:
The LP system attempts to put all items in the crafting table at once. After having crafted about a (few) stack(s) of the item the crafting process stops. New items are not being inserted into the crafting table anymore and it will just wait forever for items to appear. The items that need to be inserted into the crafting table end up back in storage, able to be requested by the player as if they are not needed for crafting.

Ideas for a solution:

  • Calculate max amount of items that can be inserted in to the table, and do not attempt to insert more than that amount at once. Items that can not fit go into storage until there is space for them.
  • Make the internal storage of the crafting table adapt to the amount of items required, so that they do not get sent back into the system.

Sidenote: this is not only the case for the specific recipe I posted above. It goes for any recipe that requires more items than fit in the crafting table. Requests above a certain amount get stuck eventually if the quantity is large enough. The above recipe gets stuck at about 200 to 500 items.

@bziemons bziemons self-assigned this Sep 8, 2022
@bziemons bziemons added Bug Accepted Will be fixed or implemented labels Sep 8, 2022
@bziemons bziemons added this to the LP 0.10.4 milestone Sep 8, 2022
@XredoFin
Copy link

XredoFin commented Sep 27, 2022

I have a similar problem, when playing Tekkit 2.
I request more than 1 high voltage water mill and some of the items do not go where needed.

I have an energy condenser setup where I keep them constantly filled with emc. The energy condensers have a chassis attached to them with crafting module, causing the system to think theres an infinite amount of resource products in that "crafting unit", which is what I want.
On that note it would be nice to have something like "infinite provider module".

I made my most used crafting tables use black hole units so that all the crafting materials are sure to fit, yet I was still missing redstone or tin, which should come from the energy condenser setup.

The materials did not go elsewhere to the system either and the energy condenser "crafting unit" did not have that glow of doing something.

On other note there are sometimes resources/products (that are crafted) left in my overflow chests that should be used, but the crafter does not receive them which makes me think that the crafting units request an incorrect amount of items.

The problem does not happen if I request only 1 hv water mill, or does it so rarely that its hard to notice.

Tekkit 2 seems to be using the version 1.12.2 - 0.10.4.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Will be fixed or implemented Bug
Projects
None yet
Development

No branches or pull requests

3 participants