Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match HardwareSerial begin signature #71

Open
dylantubular opened this issue Jun 27, 2021 · 1 comment
Open

Match HardwareSerial begin signature #71

dylantubular opened this issue Jun 27, 2021 · 1 comment

Comments

@dylantubular
Copy link

Hi!

It would be incredibly helpful if the signature of Dynamixel2Arduino's

void begin(unsigned long baud = 57600);

matched Arduino's HardwareSerial

void begin(unsigned long baud, uint32_t config=SERIAL_8N1, int8_t rxPin=-1, int8_t txPin=-1, bool invert=false, unsigned long timeout_ms = 20000UL);

In my particular case I'm using an ESP32 as a control interface and I need to remap the pins for UART2, but because the call to begin is behind Dynamixel2Arduino::begin I have to alter the library to enable this functionality.

Cheers.

@ROBOTIS-Will
Copy link
Collaborator

Hi @dylantubular

Thank you for your suggestion regarding supporting the ESP32.
Since the DYNAMIXEL2Arduino library is intended to support the official Arduino boards and ROBOTIS boards that support Arduino, I'm afraid that it would be difficult for me to spare resources to develop features for ESP32.
However, if you can contribute to improve the code, it is more than welcomed and will be reviewed for release.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants