Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: do not depend on networkD3 and webshot #364

Closed
jacobvjk opened this issue Dec 16, 2024 · 0 comments · Fixed by #367
Closed

upkeep: do not depend on networkD3 and webshot #364

jacobvjk opened this issue Dec 16, 2024 · 0 comments · Fixed by #367
Labels

Comments

@jacobvjk
Copy link
Member

jacobvjk commented Dec 16, 2024

the sankey plot is generated using networkD3 and exported by making a screenshot with webshot. This turns out to be difficult to get past extensive R-CMD checks and therefore hinders a CRAN submission.

We want to:

  • recode the sankey plot in ggplot2 and ggalluvial
  • drop the webshot and networkD3 dependencies
  • remove any interactive components in the sankey plot, keep only a static version

@jacobvjk jacobvjk changed the title upkeep: do not depends on networkD3 and webshot upkeep: do not depends on networkD3 and webshot Dec 16, 2024
@jacobvjk jacobvjk changed the title upkeep: do not depends on networkD3 and webshot upkeep: do not depend on networkD3 and webshot Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant