Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename: no-ops should not result in a failure #413

Open
atruskie opened this issue Sep 4, 2023 · 0 comments
Open

rename: no-ops should not result in a failure #413

atruskie opened this issue Sep 4, 2023 · 0 comments
Labels
area: rename bug Something isn't working

Comments

@atruskie
Copy link
Member

atruskie commented Sep 4, 2023

Sometimes when renaming a file, the new name is exactly the same as the old name.

Currently our renamer detects this in the overwrite check. However, the overwrite check does not ignore files with names that did not change. This erroneously cancels the whole rename.
@atruskie atruskie added bug Something isn't working area: rename labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: rename bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atruskie