Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed TimeEvolution to use KrylovKit instead of ExponentialUtilities #483

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jlbosse
Copy link
Contributor

@jlbosse jlbosse commented Nov 2, 2023

Implemented the changes discussed on Slack for more robust TimeEvolution gates.

I will also create a companion PR on CuYao that also removes the dependence on ExponentialUtilities

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
lib/YaoBlocks/src/YaoBlocks.jl 100.00% <ø> (ø)
lib/YaoBlocks/src/primitive/time_evolution.jl 94.44% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a fast PR! Thank you

@Roger-luo Roger-luo merged commit 7123b96 into QuantumBFS:master Nov 2, 2023
12 checks passed
@GiggleLiu
Copy link
Member

GiggleLiu commented Nov 3, 2023

Thanks, but I thought EU should be retained as an alternative backend. Any specific reason why it is removed while it is faster in some senarios? Also, since this removal of backend causes the break of CuYao: QuantumBFS/CuYao.jl#84 and this break down is quite expected. So, it should not be a patch release.

@jlbosse
Copy link
Contributor Author

jlbosse commented Nov 3, 2023

Ah sorry, yes I jumped the gun here. Rereading the discussion on Slack we did say to have both options and only make KrylovKit the default backend. I will try to create new PR this weekend doing that.

In terms of patch or breaking release, I suppose there is no way of "undoing" the current breaking release after we added EU support back in?

@GiggleLiu
Copy link
Member

Ah sorry, yes I jumped the gun here. Rereading the discussion on Slack we did say to have both options and only make KrylovKit the default backend. I will try to create new PR this weekend doing that.

In terms of patch or breaking release, I suppose there is no way of "undoing" the current breaking release after we added EU support back in?

A new PR would be perfect. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants