Fast overlap and fast add of sparse matrices #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
jlbosse
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Thanks a lot for this PR, I was actually wondering myself why the computation of the gradients was so slow compared to the expectation values!
I left two comments in the code and would generally move fast_add() and fast_overlap() to a separate "Fast sparse matrix operators" section in utils.jl instead of having them interspersed with auto diff and operator conversion code.
Otherwise this looks good and can be merged after these changes.
|
Yeah, it makes sense. I just resolved these issues. |
|
Looks great, thanks again for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice package. I profiled the transverse field ising model example program and noticed some performance issues in this package.
This is a patch to improve the performance of sparse operations. Please review this PR carefully in case I made some stupid mistake.
Benchmark
Before this patch, the time to run the example on my machine is
After this patch, it could be reduced to