Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for lattice functions #727

Closed
plquera opened this issue Oct 18, 2023 · 0 comments · Fixed by #749
Closed

Improvement for lattice functions #727

plquera opened this issue Oct 18, 2023 · 0 comments · Fixed by #749
Assignees
@weinbe58
Labels
enhancement New feature or request mod:location issues related to atoms module
Milestone
public-alpha-3

Comments

@plquera
Copy link

plquera commented Oct 18, 2023

The atom_arrangement lattices (Lieb, Square, Chain, Honeycomb, Kagome, Triangular, Rectangular) don't have an option for defining number of unit cells independently along the different primitive directions. Same for the lattice constants. (except for Rectangular)

It would probably make it better for users to have more freedom to define different form factors for their lattices in an easy way.
@plquera plquera added the enhancement New feature or request label Oct 18, 2023
@weinbe58 weinbe58 self-assigned this Oct 20, 2023
@weinbe58 weinbe58 added the mod:location issues related to atoms module label Oct 20, 2023
@weinbe58 weinbe58 linked a pull request Oct 24, 2023 that will close this issue
adding 'L2' to lattice constructors #749
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weinbe58 weinbe58

Labels
enhancement New feature or request mod:location issues related to atoms module
Projects
None yet
Milestone
public-alpha-3
Development

Successfully merging a pull request may close this issue.

adding 'L2' to lattice constructors QuEraComputing/bloqade-python
2 participants
@weinbe58 @plquera