Foreign key constraint deleting all cars for a license instead of cars related to that character

[zozomanx]

Summary

Deleting a character will trigger the foreign key cascade for all cars attached to the license instead of just the cars of the character being deleted.

Reproduction

1. Have multiple characters with the same license
2. Give cars to multiple characters
3. Delete a single character
4. Lose all of your cars on all characters

Expected behavior

Don't delete cars from other characters that are not being deleted. Just delete the cars of the character that is being deleted.

Actual behavior

All cars of all characters with the same license are deleted because of the cascade delete from the foreign key.

Additional context

I believe removing the foreign key will prevent this from happening. When a character is deleted only the cars associated to that character should be deleted, not all cars associated to the license.

FOREIGN KEY (license) REFERENCES players (license) ON DELETE CASCADE ON UPDATE CASCADE

After reviewing the delete character function it doesn't appear that the license is even used to delete characters, just the citizenID.

I wasn't 100% sure if this is used for anything else so that's why I opened this issue instead of a PR.

Current Version

1.4.1

Custom Resources

N/A