-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data always set file permission as executable #2068
Labels
bug
Something isn't working
Comments
I can create a PR if it's okay to change L1341 to remove |
blmarket
added a commit
to blmarket/maturin
that referenced
this issue
May 4, 2024
Would like to put symlink in a python module, so it will be copied to wheel package. (I know `data` is there, but it's was not working as I expected - PyO3#2068) This commit will use permission from the source file
blmarket
added a commit
to blmarket/maturin
that referenced
this issue
May 4, 2024
Would like to put symlink in a python module, so it will be copied to wheel package. (I know `data` is there, but it's was not working as I expected - PyO3#2068) This commit will use permission from the source file
blmarket
added a commit
to blmarket/maturin
that referenced
this issue
May 4, 2024
Would like to put symlink in a python module, so it will be copied to wheel package. (I know `data` is there, but it's was not working as I expected - PyO3#2068) This commit will use permission from the source file
messense
pushed a commit
that referenced
this issue
May 13, 2024
Would like to put symlink in a python module, so it will be copied to wheel package. (I know `data` is there, but it's was not working as I expected - #2068) This commit will use permission from the source file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
https://github.com/PyO3/maturin/blob/main/src/module_writer.rs#L1342
will use mode from symlink, not the linked source file. it should be read permission again from
source
file.Even after this, L1341 looks buggy to me. It tries to read parent of the source, which is usually a directory. Maybe I'm just wrong, but would like to ask devs to review.
Your maturin version (
maturin --version
)main branch
Your Python version (
python -V
)Python 3.10.0
Your pip version (
pip -V
)N/A
What bindings you're using
None
Does
cargo build
work?If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash
/
)?Steps to Reproduce
data="data"
in pyproject.tomlRUST_LOG=DEBUG maturin build
shows:The text was updated successfully, but these errors were encountered: