Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add raw file names next to link to PXD #449

Closed
mlocardpaulet opened this issue Nov 22, 2024 · 7 comments · Fixed by #493
Closed

add raw file names next to link to PXD #449

mlocardpaulet opened this issue Nov 22, 2024 · 7 comments · Fixed by #493
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@mlocardpaulet
Copy link
Contributor

Currently in the doc. we have this:

The files can be downloaded from the proteomeXchange repository PXD028735 (https://www.ebi.ac.uk/pride/archive/projects/PXD028735) or you can download them from the ProteoBench server here: https://proteobench.cubimed.rub.de/datasets/raw_files/DDA/

The link to proteomeXchange is not enough. We need to add the names of the raw files for users to find them.

@mlocardpaulet mlocardpaulet self-assigned this Nov 22, 2024
@mlocardpaulet mlocardpaulet added the documentation Improvements or additions to documentation label Nov 22, 2024
@wolski
Copy link
Contributor

wolski commented Nov 25, 2024

The previous version of Proteobench had the download links to the raw files on the main page.

These links are missing at the moment.
The new one needs these links to get everyone started.

@mlocardpaulet
Copy link
Contributor Author

mlocardpaulet commented Nov 25, 2024

what do you mean by "the main page"? We discussed in the past that it would be cleaner to have the download links with the complete explication of the module and how to use it: in the documentation. I think that it is good.
Specially because in the module page, in the tab Submit new data, there is this text:
image

What I meant when I created this issue was that in the documentation, the link to the PRIDE repo. is not enough. We need to link to individual files, or at least indicate their names. I can do it when I have some time.
Does this make sense?

We don't want to duplicate information and have these links in the module streamlit page and in the documentation.

@wolski
Copy link
Contributor

wolski commented Nov 25, 2024

I wasn't aware of this change. Makes sanse to have the information in one place.

However, the links "How to use" and "Data Set" are 'broken' in the DIANN module at the moment.

image

What are the correct links? I can try to update them.

@wolski
Copy link
Contributor

wolski commented Nov 25, 2024

Also, the link here:
https://proteobench.readthedocs.io/en/stable/available-modules/4-DIA-Quantification/
to the fasta is not working.
image

@JuliaS92
Copy link
Contributor

I just wanted to suggest something similar, when looking into it. I think it would be great, if there was a list of the actual direct links to the ftp servers for each raw file like so: https://ftp.pride.ebi.ac.uk/pride/data/archive/2022/02/PXD028735/LFQ_Orbitrap_AIF_Condition_A_Sample_Alpha_01.raw
Then nobody needs to read any description of which files to download and which ones not.

@mlocardpaulet
Copy link
Contributor Author

I just wanted to suggest something similar, when looking into it. I think it would be great, if there was a list of the actual direct links to the ftp servers for each raw file like so: https://ftp.pride.ebi.ac.uk/pride/data/archive/2022/02/PXD028735/LFQ_Orbitrap_AIF_Condition_A_Sample_Alpha_01.raw Then nobody needs to read any description of which files to download and which ones not.

Yes! Absolutely. Actually, it is the way it was in the past.

@mlocardpaulet
Copy link
Contributor Author

Also, the link here: https://proteobench.readthedocs.io/en/stable/available-modules/4-DIA-Quantification/ to the fasta is not working. image

This was fixed here for DDA.
https://github.com/Proteobench/ProteoBench/pull/450/files
I can make the change later.

@mlocardpaulet mlocardpaulet linked a pull request Dec 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants