Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse fragpipe params differently for DIA and DDA #429

Closed
rodvrees opened this issue Nov 4, 2024 · 4 comments
Closed

Parse fragpipe params differently for DIA and DDA #429

rodvrees opened this issue Nov 4, 2024 · 4 comments
Assignees
@wolski @rodvrees

Comments

@rodvrees
Copy link
Contributor

rodvrees commented Nov 4, 2024

We have distinct parameters that need to be parsed from the fragpipe.workflow file for DDA and DIA data analysis. At the moment, no distinction is made and DDA params are being parsed for both DDA and DIA modules.
@rodvrees rodvrees self-assigned this Nov 4, 2024
@rodvrees
Copy link
Contributor Author

rodvrees commented Nov 4, 2024

Same goes for MaxQuant/MaxDIA

@wolski wolski self-assigned this Dec 2, 2024
@RobbinBouwmeester
Copy link
Contributor

@rodvrees, is this still an issue?

@rodvrees
Copy link
Contributor Author

rodvrees commented Dec 9, 2024

Yes, but should be easily fixed now after the refactoring

@rodvrees
Copy link
Contributor Author

rodvrees commented Dec 9, 2024

Also, it comes down as a more specific #434, so IMO you can remove this issue and we work with that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolski wolski

@rodvrees rodvrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wolski @RobbinBouwmeester @rodvrees