diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index fffa067..0000000 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,19 +0,0 @@ - - -| Questions | Answers -| ------------- | ------------------------------------------------------- -| Description? | Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table. -| Type? | bug fix / improvement / new feature / refacto / critical -| BC breaks? | yes / no -| Deprecations? | yes / no -| Fixed ticket? | Fixes PrestaShop/PrestaShop#{issue number here}. -| How to test? | Please indicate how to best verify that this PR is correct. - - diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index 2479b9d..28ba23f 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -2,59 +2,6 @@ name: Build on: [push, pull_request] jobs: - deploy: - name: build dependencies & create artifact - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2.0.0 - - name: Install composer dependencies - run: composer install --no-dev -o - - name: Clean-up project - uses: PrestaShopCorp/github-action-clean-before-deploy@v1.0 - - name: Prepare auto-index tool - run: composer global require prestashop/autoindex - - name: Generate index.php - run: ~/.composer/vendor/bin/autoindex - - name: Create & upload artifact - uses: actions/upload-artifact@v1 - with: - name: ${{ github.event.repository.name }} - path: ../ - update_release_draft: - runs-on: ubuntu-latest - needs: [deploy] - if: github.event_name == 'push' && github.event.ref == 'refs/heads/master' - steps: - - name: Download artifact - uses: actions/download-artifact@v1 - with: - name: ${{ github.event.repository.name }} - - id: release_info - uses: toolmantim/release-drafter@v5 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Prepare for Release - run: | - cd ${{ github.event.repository.name }} - zip -r ${{ github.event.repository.name }}.zip ${{ github.event.repository.name }} - - name: Clean existing assets - shell: bash - run: | - curl -fsSL https://github.com/github/hub/raw/master/script/get | bash -s 2.14.1 - assets=`bin/hub api -t repos/${{ github.repository }}/releases/${{ steps.release_info.outputs.id }}/assets | awk '/\].url/ { print $2 }'` - for asset in $assets - do - bin/hub api -X DELETE $asset - done - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Publish to GitHub Release - uses: actions/upload-release-asset@v1.0.1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - upload_url: ${{ steps.release_info.outputs.upload_url }} - asset_path: ./${{ github.event.repository.name }}/${{ github.event.repository.name }}.zip - asset_name: ${{ github.event.repository.name }}.zip - asset_content_type: application/zip + build-and-release-draft: + name: Build & Release draft + uses: PrestaShop/.github/.github/workflows/build-release.yml@master diff --git a/README.md b/README.md index d4275e6..c70719a 100644 --- a/README.md +++ b/README.md @@ -4,11 +4,26 @@ Add sliding images to your homepage to welcome your visitors in a visual and friendly way. +## Compatibility + +PrestaShop: `1.7.4.0` or later + ## Multistore compatibility This module is not compatible with the multistore :x:
It means that its configuration applies for all stores. +## How to test + +Link to specs : https://docs.prestashop-project.org/functional-documentation/functional-documentation/ux-ui/back-office/improve/modules/image-slider-ps_imageslider + +Settings +- Configure Settings and check the results on FO +Slides list +- CRUD +- Enable/disable +- Reposition + ## Reporting issues You can report issues with this module in the main PrestaShop repository. [Click here to report an issue][report-issue]. diff --git a/config.xml b/config.xml index f94a30e..49fe122 100644 --- a/config.xml +++ b/config.xml @@ -2,7 +2,7 @@ ps_imageslider - + diff --git a/ps_imageslider.php b/ps_imageslider.php index 99eea5b..3dbbf28 100644 --- a/ps_imageslider.php +++ b/ps_imageslider.php @@ -52,7 +52,7 @@ public function __construct() { $this->name = 'ps_imageslider'; $this->tab = 'front_office_features'; - $this->version = '3.1.3'; + $this->version = '3.1.4'; $this->author = 'PrestaShop'; $this->need_instance = 0; $this->secure_key = Tools::hash($this->name); @@ -119,9 +119,6 @@ public function install() $this->installSamples(); } - // Disable on mobiles and tablets - $this->disableDevice(Context::DEVICE_MOBILE); - return (bool) $res; } @@ -143,9 +140,7 @@ protected function installSamples() $slide->description[$language['id_lang']] = '

EXCEPTEUR OCCAECAT

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin tristique in tortor et dignissim. Quisque non tempor leo. Maecenas egestas sem elit

'; $slide->legend[$language['id_lang']] = 'sample-' . $i; - $slide->url[$language['id_lang']] = 'https://www.prestashop-project.org?utm_source=back-office&utm_medium=v17_homeslider' - . '&utm_campaign=back-office-' . Tools::strtoupper($this->context->language->iso_code) - . '&utm_content=' . (defined('_PS_HOST_MODE_') ? 'ondemand' : 'download'); + $slide->url[$language['id_lang']] = 'https://www.prestashop-project.org'; $rtlSuffix = $language['is_rtl'] ? '_rtl' : ''; $slide->image[$language['id_lang']] = sprintf('sample-%d%s.jpg', $i, $rtlSuffix); }