Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Pool and Work Queue update events #16658

Open
soamicharan opened this issue Jan 9, 2025 · 3 comments
Open

Work Pool and Work Queue update events #16658

soamicharan opened this issue Jan 9, 2025 · 3 comments
Labels
enhancement An improvement of an existing feature good first issue This issue is good for newcomers

Comments

@soamicharan
Copy link
Contributor

Describe the current behavior

The current behavior of work pool and work queue updates are if work pool/work queue status is updated then only creates a Event record in database. If Work Pool/Work Queue any other fields are updated then there is no event is created in database.

Describe the proposed behavior

Whenever work pool/work queue fields are updated then it should create a event in database so we can create some automations around work pool/work queue updates.

Example Use

One of example use case is that whenever work pool concurrency limit is updated OR work queue priority changes then we can write automations to handle subsequent actions to either notify on slack or scale resources accordingly.

Additional context

No response

@soamicharan soamicharan added the enhancement An improvement of an existing feature label Jan 9, 2025
@zzstoatzz
Copy link
Collaborator

zzstoatzz commented Jan 13, 2025

hi @soamicharan - thanks for the issue!

this makes sense to me on face value, the only hesitation I'd have is around making sure we don't have too many events emitted by default (so maybe a setting?).

are you interested in contributing a PR for this?

@zzstoatzz zzstoatzz added the good first issue This issue is good for newcomers label Jan 13, 2025
@soamicharan
Copy link
Contributor Author

@zzstoatzz if we may generalize this enhancement then we can have setting that enables to push events if specific data is created/updated/deleted from database.
For example Work_queues, wotk_pool, deployments, flows table row is updated/created /deleted we can create a event
We can generate events by using SQLAlchemy orm events?

@zzstoatzz
Copy link
Collaborator

zzstoatzz commented Jan 14, 2025

@soamicharan if I'm understanding correctly, events for all CRUD operations is something we could certainly explore in a discussion, but would likely be outside the scope of this issue as written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature good first issue This issue is good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants