Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tcgplayer.com API IDs #91

Open
blacktide082 opened this issue Jul 28, 2020 · 0 comments
Open

Include tcgplayer.com API IDs #91

blacktide082 opened this issue Jul 28, 2020 · 0 comments

Comments

@blacktide082
Copy link

I noticed that Scryfall's API for MTG includes a tcgplayer_id field which allows the users of their API to map the MTG card or set to the product on tcgplayer.com.

I was wondering if you would be open to including the tcgplayer.com ID for cards, and possibly even the group ID for sets. To find the price for a card as the API currently stands, I need to maintain a mapping of the pokemon-tcg-api "set codes" to the tcgplayer.com "group IDs" to get a list of products for that set, and then try to match the product based on the card number using the extendedData of each product (which doesn't always work as perfectly as one would hope).

If you're open to the idea, I would be happy to help implement this. I can use the existing logic from my personal app to update the JSON files in the pokemon-tcg-data repo for it and submit a PR over there for it.

Reference Links:

TL;DR - Can we add a tcgPlayerId field to sets/cards to easily relate them to their respective groups/products on tcgplayer.com?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants