You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/** \brief Set the maximum allowed Euclidean error between two consecutive steps in
The doc claims that the epsilon refers to the "maximum allowed Euclidean error between two consecutive steps" in the registration. This does not seem to be correct or perhaps not well formulated at least for IterativeClosestPoint, where the value is passed to DefaultConvergenceCriteria where it is used as the relative reduction in MSE between two steps. i.e. a value of 0.01 does not mean "converge when current MSE < 0.01", but rather "converge when reduction in MSE from last iteration is less than 1% of MSE from last iteration".
I'm not sure if the documentation should be updated, since other subclasses may use it differently, or if the entire function should move to the icp class, since only ICP and JointICP seem to actually use it.
The text was updated successfully, but these errors were encountered:
themightyoarfish
changed the title
Documentation about Registration::setEuclideanFitnessEpsilon() incorrect
Documentation about Registration::setEuclideanFitnessEpsilon() misleading
Nov 7, 2023
pcl/registration/include/pcl/registration/registration.h
Line 395 in 81b92a5
The doc claims that the epsilon refers to the "maximum allowed Euclidean error between two consecutive steps" in the registration. This does not seem to be correct or perhaps not well formulated at least for
IterativeClosestPoint
, where the value is passed toDefaultConvergenceCriteria
where it is used as the relative reduction in MSE between two steps. i.e. a value of 0.01 does not mean "converge when current MSE < 0.01", but rather "converge when reduction in MSE from last iteration is less than 1% of MSE from last iteration".I'm not sure if the documentation should be updated, since other subclasses may use it differently, or if the entire function should move to the icp class, since only ICP and JointICP seem to actually use it.
The text was updated successfully, but these errors were encountered: