Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build very sensitive to compiler differences, consider having a "strict" option #361

Open
timkpaine opened this issue Sep 3, 2024 · 0 comments
Open

Build very sensitive to compiler differences, consider having a "strict" option #361

timkpaine opened this issue Sep 3, 2024 · 0 comments
Labels
part: build Issues and PRs related to the build process type: enhancement Issues and PRs related to improvements to existing features

Comments

@timkpaine
Copy link
Member

Compilers might have different considerations for what is, and what is not, a warning. Example: #359

For perspective for example, we had a "STRICT" flag: https://github.com/finos/perspective/blob/08448ccc7ad8b9ca2c98659b1c8187e7ab40aa68/cpp/perspective/CMakeLists.txt#L73
We should consider doing something similar. We can enable it in CI/locally where we have full control over the env, but allow it to be unset for end users that might be building from source against other compilers.
@timkpaine timkpaine added type: enhancement Issues and PRs related to improvements to existing features part: build Issues and PRs related to the build process labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part: build Issues and PRs related to the build process type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timkpaine