Declare arguments before local variables

[Beliavsky]

Fortitude does not complain about the code below, but procedure arguments should be declared before local variables, and arguments should be declared in the order they appear.

module m
implicit none
integer, parameter :: dp = kind(1.0d0)
contains
subroutine mean_sd(x, xmean, xsd)
integer :: i, n
real(kind=dp) :: xsum, xsumsq
real(kind=dp), intent(out) :: xsd, xmean
real(kind=dp), intent(in) :: x(:)
n = size(x)
xsum = 0.0_dp
do i=1,n
   xsum = xsum + x(i)
end do
xmean = xsum/n
xsumsq = sum((x-xmean)**2)
xsd = sqrt(xsumsq/n)
end subroutine mean_sd
end module m

[ZedThree]

I think this is a fairly obvious style rule we should have

[Beliavsky]

One caveat is that named constants used in declarations should appear before the declarations, as in

module m
implicit none
contains
subroutine prnt(x)
integer, parameter :: n = 2, dp = kind(1.0d0)
real(kind=dp), intent(in) :: x(n)
print*,x(1)
print*,x(2)
end subroutine prnt
end module m

Thanks for considering so many of my suggestions. They are all based on codes I have seen!

[ZedThree]

Thanks for considering so many of my suggestions. They are all based on codes I have seen!

They've been really useful, thanks -- keep them coming! Of course, if you also want to implement any of them, that would also be very much appreciated 😄