Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expansion work when parsed for null as well. #52

Open
BlitzOffline opened this issue Nov 10, 2021 · 0 comments
Open

Make expansion work when parsed for null as well. #52

BlitzOffline opened this issue Nov 10, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BlitzOffline
Copy link
Member

From what I can see there is no need for the expansion to require offline player and it looks quite easy to make it work with null players. From what I can tell you just have to remove the null checks and in the evaluate method you add some extra checks when adding the bindings for offline player since PlaceholderAPI#setPlaceholders and #setBracketPlaceholders both work with null.

@BlitzOffline BlitzOffline added good first issue Good for newcomers enhancement New feature or request labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant